Skip to content

fix: remove legacy V1 ULN references from DVNMock.sol to fix V2 compile errors. #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thesandf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove legacy V1 ULN references from DVNMock.sol to fix V2 compile errors. #1903

thesandf wants to merge 2 commits into from

Conversation

@thesandf
Copy link

@thesandf thesandf commented Jan 18, 2026

Fixes compile errors like:

Error (6275): Source "@layerzerolabs/lz-evm-v1-0.7/contracts/interfaces/ILayerZeroUltraLightNodeV2.sol" not found...

when using devtools (via lz-address-book) in pure V2 Foundry setups.

The V1 import and withdrawFeeFromUlnV2 are legacy ULNv2 helpers. Since devtools focuses on Endpoint V2 testing (TestHelperOz5 etc.), removing them eliminates the bad dependency without breaking modern usage.

Changes:

  • Deleted V1 import
  • Removed withdrawFeeFromUlnV2 function
  • Updated _shouldCheckHash to exclude V1 selector

Testing:

  • pnpm build && pnpm test in devtools → passes
  • In test Foundry project: pointed dependency to this fork → forge build succeeds, no file not found error

Happy to adjust if legacy support should be kept (e.g., as optional or stubbed).

nazreen and others added 2 commits January 18, 2026 09:51
@nazreen @thesandf
DEVREL-930 Oapp solana migrate lzrt v2 (LayerZero-Labs#1850)
e69f49f
@thesandf
fix: remove legacy V1 ULN references from DVNMock.sol
57c731c 
This resolves 'file not found' compile errors for @layerzerolabs/lz-evm-v1-0.7
in V2-only Foundry projects (e.g. via lz-address-book dependency), since no remapping
exists for the old V1 path.

Changes:
- Removed ILayerZeroUltraLightNodeV2 import
- Deleted withdrawFeeFromUlnV2 function (legacy ULNv2 support, redundant in V2 mocks)
- Cleaned _shouldCheckHash by removing V1 selector reference

Tested: forge build succeeds in sample project with TestHelperOz5 after overriding to this branch.
@cursor
Copy link

cursor bot commented Jan 18, 2026 •
edited
Loading

PR Summary

Migrates the Solana OApp example to the V2 execution model and removes lingering V1 dependencies.

  • Introduces LzReceiveTypesV2 flow: adds lz_receive_types_v2 and lz_receive_types_info instructions; removes legacy lz_receive_types V1
  • Updates program/state: new LzReceiveTypesAccounts fields (alt, bump), lz_receive now takes a payer; init_store can record optional ALT
  • Regenerates TypeScript SDK: new V2 types (AddressLocator, AccountMetaRef, Instruction, LzReceiveTypesV2Result), new client instructions, program ID placeholders
  • Adds Hardhat tasks: EVM debug (lz:oapp:evm:debug) and Solana create accepts --alt; README documents debugging stored strings
  • Tweaks config/docs/comments; minor gas/confirmations values adjusted in layerzero.config.ts
  • Devtools Foundry: removes ULNv1 import and helper from DVNMock.sol, and excludes V1 selector in _shouldCheckHash

Written by Cursor Bugbot for commit 57c731c. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thesandf @nazreen